opa check: only check schema types when user provides schemas #7124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this needs further iteration - the test suite informed me that inline schemas should always be validated. Will fix. |
|
@tjons — yeah, I imagine this may turn out to be a can of worms, lol
👍 @johanfylling may have some ideas too |
tjons
force-pushed
the
tjons/7116-schemas-annotations
branch
2 times, most recently
from
afb58c8
to
a100455
Compare
Signed-off-by: Tyler Schade <[email protected]> only check schemas when schemas are provided Signed-off-by: Tyler Schade <[email protected]>
tjons
force-pushed
the
tjons/7116-schemas-annotations
branch
from
a100455
to
16cdb08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
v0.69.0caused a regression inopa checkwhere a file that referenced non-provided schemas now fails validation. This PR fixes the regression and restores the behavior fromv0.68.0.What are the changes in this PR?
Resolves #7116 by only adding the
useTypeCheckAnnotationsoption if the user has provided a path to schemas to validate.This regression was introduced in 76f7038. In that commit, the signature of the
processAnnotationsmethod changed: 76f7038#diff-d23ff3bfce1aa610d34183f8ccab5ecfd112e19dd9ebca55d69f231a29b62337R227. The annotation'spathwill nearly always exist, causing the checker to attempt to validate it and error because its schema is not found.An alternate approach would be to return early if the type of the
annotationisnil, similar to how thepathwas handled inv0.68.0.Notes to assist PR review:
Further comments: