planner: fix with replacement with local-var values #6996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every function down the call stacks of a with-replacement that does this will now get extra variables added to its args to carry along the local variables that will eventually be needed to replace the with-mocked func call. TODOs: - [ ] think hard about variable name clashes (do we need a func for this?) - [ ] more test cases Fixes open-policy-agent#5311. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
commented
Sep 5, 2024
| @@ -160,7 +160,7 @@ func (p *Planner) buildFunctrie() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (p *Planner) planRules(rules []*ast.Rule) (string, error) { | |||
| func (p *Planner) planRules(rules []*ast.Rule, extras ...*ast.Term) (string, error) { | |||
There was a problem hiding this comment.
This is a shortcut -- I didn't want to adjust all call sites, but only the one where I'd like to have extra args injected...
|
TBC. this approach works well with "proper" functions, but not with rules... their eval is driven by planRefData and planRules is all over the place there. It's less approachable to add extra arguments 💭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every function down the call stacks of a with-replacement that does this will now get extra variables added to its args to carry along the local variables that will eventually be needed to replace the with-mocked func call.
TODOs:
Fixes #5311.