comm: couple of enhancements wrt pmix groups #12996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a pmix timeout option for group operations. This may be a no-op with certain pmix server variants but set it anyway. For protection make sure when creating intercomm communicators using pmix group construct that all procs supply the same ordered list of pmix procs to pmix group construct. update the description for ompi_mca_mpi_pmix_connect_timeout to not it can be used to control timeout for pmix group calls as well. Signed-off-by: Howard Pritchard <[email protected]>
rhc54
reviewed
Dec 23, 2024
| @@ -383,24 +395,51 @@ static int ompi_comm_ext_cid_new_block (ompi_communicator_t *newcomm, ompi_commu | |||
| pinfo = (pmix_info_t*)darray.array; | |||
| ninfo = darray.size; | |||
|
|
|||
| proc_count = newcomm->c_local_group->grp_proc_count; | |||
| /* | |||
| * Make sure all processes participating in the PMIx group construct operation | |||
There was a problem hiding this comment.
PLEASE don't do this! The last PMIx version that needed this was years ago in the v3 series, which OMPI does not support. The Standard has been updated to stipulate that order is not guaranteed, so we won't see it return.
All this does is add more overhead for no value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a pmix timeout option for group operations.
This may be a no-op with certain pmix server variants but set it anyway.
For protection make sure when creating intercomm communicators using pmix group construct that all procs supply the same ordered list of pmix procs to pmix group construct.
update the description for ompi_mca_mpi_pmix_connect_timeout to not it can be used to control timeout for pmix group calls as well.