coll/accelerator initial enhancements #12986
Open
+191
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make use of the correct device id associated with a device buffer and provide the correct transfer type (DTOH or HTOD) for the accelerator memcpy operations. This information can be potentially used for some optimizations internally. Signed-off-by: Edgar Gabriel <[email protected]>
This PR introduces the ability to register the component only to the select functions specified by an MCA parameter string. The idea and the code is based on the UCC component, and some of the bits might be moved later to coll/base to make the mechanism more gnerally available to other components as well. Note, that the PR introduces the define statments for all MPI collective operations, not just the ones support by the component at the moment, since it is a bitmask based operation, and we anticipate to add support for more collective operations into coll/accelerator shortly Signed-off-by: Edgar Gabriel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two enhancements to the coll/accelerator component:
use the device_id and the transfer direction for the accelerator.mem_copy operations: since this information is actually available, we might as well use it and give the accelerator components the ability to potential use this information for tuning purposes.
introduce the ability to register the component only for the operations that were provided by the end-user as an MCA parameter. This mimics closely the feature of the coll/ucc component, and the code is in fact based on the coll/ucc component code (with some minor modifications/adjustments).
These PRs are in preparation for additional work on the coll/accelerator component, I just want to avoid having a gigantic PR that is harder to digest.