sessions: add smoke test #12893
Merged
sessions: add smoke test #12893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
requested changes
Oct 30, 2024
|
this PR will not pass CI until #12883 is merged into the v5.0.x branch. |
hppritcha
force-pushed
the
pr12871_back_to_v50x
branch
from
912239d to
0d3fe46
Compare
jsquyres
approved these changes
Oct 30, 2024
|
Amusing -- your new test is failing on this PR. 😆 |
done, merged |
janjust
approved these changes
Oct 30, 2024
and add to mac os github CI Signed-off-by: Howard Pritchard <[email protected]> (cherry picked from commit 9109c33)
when there are no more refs to opal util layer. Update sessions smoke test to illustrate the issue in case this change gets reverted or undone by some future commit. examples: add return 0 to sessions smoke test Signed-off-by: Howard Pritchard <[email protected]> (cherry picked from commit 70e51fe) (cherry picked from commit 6cf4dbe)
hppritcha
force-pushed
the
pr12871_back_to_v50x
branch
from
0d3fe46 to
be59665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add to mac os github CI
Signed-off-by: Howard Pritchard [email protected]
(cherry picked from commit 9109c33)
we need this PR before another one with a bug fix can be pushed to v5.0.x