accelerator/rocm: adjust rocm mca parameter names #12721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
changed the title
edgargabriel
force-pushed
the
topic/rocm-mca-parameters-fix
branch
from
b5cab9b to
320fbb0
Compare
wenduwan
approved these changes
Jul 29, 2024
make the mca parameters of the accelerator/rocm component being recognized as parameters of the component, instead of generic mpi parameters. The original mca parameter names stem from the times when the rocm component was in mca/common/rocm/ instead of a component. We are however keeping the old names as synonyms, e.g. "accelerator_rocm_memcpy_async" (..., synonyms: mpi_accelerator_rocm_memcpy_async) Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel
force-pushed
the
topic/rocm-mca-parameters-fix
branch
from
320fbb0 to
989243a
Compare
make the same adjustments for the parameter names for ze as was done for rocm component, for the sake of consistency. The cuda componet does not register its parameters in the component itself, so this would be a bigger change. Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel
force-pushed
the
topic/rocm-mca-parameters-fix
branch
from
989243a to
b44ecf0
Compare
|
@wenduwan could you please also re-review this pr? I have updated it to add the MCA_BASE_VAR_SYN_FLAG_DEPRECATED when registering the synonyms using the old parameter names, and I applied the same change to the ze component. The cuda component unfortunately does not register its mca parameters in the accelerator/cuda component, that might be a bigger change. |
wenduwan
approved these changes
Jul 30, 2024
|
@hppritcha if you have a short minute., could you please check whether this pr is good to go? Since it touches the ze component, I would prefer to have your approval |
hppritcha
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the mca parameters of the accelerator/rocm component being recognized as parameters of the component, instead of generic mpi parameters. The original mca parameter names stem from the times when the rocm code was in opal/rocm/ instead of a component.
We are however keeping the old names as synonyms, e.g.
"accelerator_rocm_memcpy_async" (..., synonyms: mpi_accelerator_rocm_memcpy_async)