-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow: add MacOS compile check #12696
Conversation
60aad92
to
894b472
Compare
FYI @dalcinl I copied your setup script from https://github.com/mpi4py/mpi-publish/blob/master/.github/workflows/cd-wheel.yml#L126 I believe our licenses are compatible. |
@wenduwan Why did you call the workflow file |
@wenduwan Is there any quick |
@wenduwan Wouldn't be a bad thing to do a I wouldn't worry too much about |
Increase CI coverage to prevent open-mpi#12693 Signed-off-by: Wenduo Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only runs a single ring_c test, but that's good enough for now (i.e., it's good enough as a sanity test). Let's merge this now and add more macos testing over time.
Increase CI coverage to prevent #12693