coll/accelerator initial enhancements #12986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Looks good but I think we should have this mechanism provided from base and applied consistently across all collective modules. Maybe we can split this in two, merge the first commit (adding the dev_id and transfer type) and I volunteer to make the coll selection mechanism generic.
make use of the correct device id associated with a device buffer and provide the correct transfer type (DTOH or HTOD) for the accelerator memcpy operations. This information can be potentially used for some optimizations internally. Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel
force-pushed
the
topic/coll-accelerator-extension
branch
from
519234a to
118c1b0
Compare
bosilca
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation for additional work on the coll/accelerator component, I just want to avoid having a gigantic PR that is harder to digest.