Skip to content

Commit

Permalink
request: correctly handle MPI_COMM_NULL
Browse files Browse the repository at this point in the history
ompi_request_check_same_instance(): ignore requests whose communicator
is ompi_mpi_comm_null. That can occur when pml/ucx is used and
mca_pml_ucx_completed_request_init() was invoked.

Thanks Christian Huettig for the report and helping with the troubleshooting.

Refs. #12942

Signed-off-by: Gilles Gouaillardet <[email protected]>
(cherry picked from commit 607f3a4)
  • Loading branch information
ggouaillardet authored and janjust committed Dec 17, 2024
1 parent f0462e0 commit 0456542
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions ompi/request/request.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
* Copyright (c) 2012 Oak Ridge National Labs. All rights reserved.
* Copyright (c) 2015 Los Alamos National Security, LLC. All rights
* reserved.
* Copyright (c) 2015 Research Organization for Information Science
* and Technology (RIST). All rights reserved.
* Copyright (c) 2015-2024 Research Organization for Information Science
* and Technology (RIST). All rights reserved.
* Copyright (c) 2018 FUJITSU LIMITED. All rights reserved.
* Copyright (c) 2018 Triad National Security, LLC. All rights
* reserved.
Expand Down Expand Up @@ -267,6 +267,8 @@ bool ompi_request_check_same_instance(ompi_request_t** requests,
base_instance = req->req_mpi_object.comm->instance;
continue;
}
if(&ompi_mpi_comm_null.comm == req->req_mpi_object.comm)
continue;
if(base_instance != req->req_mpi_object.comm->instance)
return false;
}
Expand Down

0 comments on commit 0456542

Please sign in to comment.