Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix compiled error on windows #1543

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Dec 1, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix compiled error on windows when the version of PyTorch is less than 1.8.0.

Before PyTorch1.8.0, when compiling CUDA code, cxx is a required key passed to PyTorch. Even if there is no flag passed
to cxx, the user also needs to pass an empty list to PyTorch. Since PyTorch1.8.0, it has a default value so users do not need
to pass an empty list anymore. More details at pytorch/pytorch#45956.

Modification

setup.py

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida
Copy link
Collaborator Author

zhouzaida commented Dec 1, 2021

Compiled environment

  • MMCV Compiler: MSVC 192930137
  • MMCV CUDA Compiler: 10.2

Record some issues when I compiled mmcv-full on Windows with PyTorch1.5.0 - 1.7.0.

PyTorch1.5.0

PyTorch1.6.0

PyTorch1.7.0

@zhouzaida
Copy link
Collaborator Author

Compiled successfully on Windows with Torch1.5.0, Torch1.6.0, Torch1.7.0 and Torch1.8.0.

@ZwwWayne ZwwWayne merged commit a7c1016 into open-mmlab:master Dec 1, 2021
@zhouzaida zhouzaida deleted the fix-compiled-error branch December 6, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants