Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme #17

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Updated Readme #17

wants to merge 11 commits into from

Conversation

anurag8546
Copy link

Added new features to Readme.md

anurag8546 and others added 7 commits May 4, 2022 13:23
Copy link
Member

@johnwalicki johnwalicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. This looks great. Can you make 2 changes before we merge this.

  • Remove the unnecessary <br> lines from your commit.
  • Remove one of the trailing newlines from your commit.

Thanks so much for joining the Open Horizon community.

Copy link
Member

@johnwalicki johnwalicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joewxboy Are we moving the CODE_OF_CONDUCT.md or CONTRIBUTING.md for all of the repositories into this .github profile?

@johnwalicki
Copy link
Member

Some of the commits are messy multiple edits to links. Maybe we could recommend to squash this into one commit ?

@johnwalicki
Copy link
Member

@anurag8546 It would be great to merge your contribution into the Open Horizon project. See above for some requested changes. Can you git squash these commits and sign the DCO?

@joewxboy
Copy link
Member

@joewxboy Are we moving the CODE_OF_CONDUCT.md or CONTRIBUTING.md for all of the repositories into this .github profile?

@johnwalicki It does make sense to consolidate the CONTRIBUTING for all of the repos if we can automate it.

For the Code of Conduct, we should not be hosting a copy ourselves but instead linking to the standard Linux Foundation CoC, which is what the TSC adopted in our Technical Charter (posted on the wiki).

@anurag8546
Copy link
Author

@joewxboy I've done both the required changes -

  1. Removed unnecessary
    from code
  2. Removed the trailing newline from the commit.

This still gives all checks have failed.

@anurag8546
Copy link
Author

@joewxboy I've done both the required changes -

  1. Removed unnecessary from code
  2. Removed the trailing newline from the commit.

This still gives all checks have failed.

@johnwalicki

@@ -10,7 +10,7 @@
<a href="https://github.com/open-horizon?tab=repositories"><img src="https://badges.pufler.dev/repos/open-horizon" alt="Open Horizon" /> </a>
<img src="https://img.shields.io/github/stars/open-horizon?label=Stars" alt="Total Stars">
<!--
<a href="https://twitter.com/lf_edge)" alt="twitter"><img src="https://img.shields.io/badge/twitter-@lf_edge--twitter-yellow.svg" alt="twitter"></img></a>
<a href="https://twitter.com/lf_edge" alt="twitter"><img src="https://img.shields.io/badge/twitter-@lf_edge--twitter-yellow.svg" alt="twitter"></img></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove closing </img> tag. Image is not an HTML container, so it does not have a closing tag in HTML 4.x and HTML 5.

@joewxboy
Copy link
Member

@anurag8546 When you click on each individual commit, you are shown details about which checks are failing for that specific commit, and potentially how to resolve them. Here's one:
https://github.com/open-horizon/.github/pull/17/checks

Let me know if the description on how to sign the commits is unclear or hard to follow.

@johnwalicki
Copy link
Member

@anurag8546 It would be great to merge your contribution into the Open Horizon project. See above for some requested changes. Can you git squash these commits and sign the DCO?

@joewxboy
Copy link
Member

@anurag8546 Are you available to amend your commits to add a sign-off? That will allow this PR to be merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants