-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Readme #17
base: master
Are you sure you want to change the base?
Updated Readme #17
Conversation
Update README.md
Signed-off-by: Ayush Kumar <[email protected]> Signed-off-by: Anurag Mishra <[email protected]>
Signed-off-by: Ayush Kumar <[email protected]> Signed-off-by: Anurag Mishra <[email protected]>
Signed-off-by: Ayush Kumar <[email protected]> Signed-off-by: Anurag Mishra <[email protected]>
Signed-off-by: Anurag Mishra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. This looks great. Can you make 2 changes before we merge this.
- Remove the unnecessary
<br>
lines from your commit. - Remove one of the trailing newlines from your commit.
Thanks so much for joining the Open Horizon community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joewxboy Are we moving the CODE_OF_CONDUCT.md or CONTRIBUTING.md for all of the repositories into this .github profile?
Some of the commits are messy multiple edits to links. Maybe we could recommend to squash this into one commit ? |
@anurag8546 It would be great to merge your contribution into the Open Horizon project. See above for some requested changes. Can you git squash these commits and sign the DCO? |
@johnwalicki It does make sense to consolidate the CONTRIBUTING for all of the repos if we can automate it. For the Code of Conduct, we should not be hosting a copy ourselves but instead linking to the standard Linux Foundation CoC, which is what the TSC adopted in our Technical Charter (posted on the wiki). |
fixed typo in the twitter link
updated Readme.md
@joewxboy I've done both the required changes -
This still gives all checks have failed. |
|
@@ -10,7 +10,7 @@ | |||
<a href="https://github.com/open-horizon?tab=repositories"><img src="https://badges.pufler.dev/repos/open-horizon" alt="Open Horizon" /> </a> | |||
<img src="https://img.shields.io/github/stars/open-horizon?label=Stars" alt="Total Stars"> | |||
<!-- | |||
<a href="https://twitter.com/lf_edge)" alt="twitter"><img src="https://img.shields.io/badge/twitter-@lf_edge--twitter-yellow.svg" alt="twitter"></img></a> | |||
<a href="https://twitter.com/lf_edge" alt="twitter"><img src="https://img.shields.io/badge/twitter-@lf_edge--twitter-yellow.svg" alt="twitter"></img></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove closing </img>
tag. Image is not an HTML container, so it does not have a closing tag in HTML 4.x and HTML 5.
@anurag8546 When you click on each individual commit, you are shown details about which checks are failing for that specific commit, and potentially how to resolve them. Here's one: Let me know if the description on how to sign the commits is unclear or hard to follow. |
@anurag8546 It would be great to merge your contribution into the Open Horizon project. See above for some requested changes. Can you git squash these commits and sign the DCO? |
@anurag8546 Are you available to amend your commits to add a sign-off? That will allow this PR to be merged. Thanks. |
Added new features to Readme.md