Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename custom authorizer to Lambda authorizer #810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

galer7
Copy link

@galer7 galer7 commented Nov 3, 2022

AWS renamed customer authorizer to Lambda authorizer, as per docs.
Previous link routes to welcome page now.

AWS renamed customer authorizer to Lambda authorizer, as per docs.
@galer7 galer7 changed the title Rename custom authorizer to Lambda authorizer fix: Rename custom authorizer to Lambda authorizer Nov 3, 2022
Copy link

@dsabalete dsabalete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@darigovresearch darigovresearch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galer7 Thanks for the pull request

Do the maintainers need anything else for the pull request to be merged?

@galer7
Copy link
Author

galer7 commented Nov 5, 2022

@darigovresearch No problem!
I don't think so, but let me know if I can be of any more help.

@galer7 galer7 closed this Sep 2, 2023
@stevewright82
Copy link

@galer7 - you closed this. I'm curious, because it didn't get merged. Does anyone know who can approve merges?

@galer7
Copy link
Author

galer7 commented Sep 4, 2023

Hey @stevewright82, I think this PR requires another approval, but I don't know where to get it from 😄.
The changes are still valid, as the current link points to the wrong page.

@galer7 galer7 reopened this Sep 4, 2023
@stevewright82
Copy link

Hey @stevewright82, I think this PR requires another approval, but I don't know where to get it from 😄. The changes are still valid, as the current link points to the wrong page.

I've messaged @jlevy @ThanosBaskous and @QuinnyPig in the og-aws Slack to see if they can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants