Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass flag_metadata from resolution to evaluation details #212

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

federicobond
Copy link
Member

This PR

Implements Requirement 1.4.14

If the flag metadata field in the flag resolution structure returned by the configured provider is set, the evaluation details structure's flag metadata field MUST contain that value. Otherwise, it MUST contain an empty record.

@federicobond federicobond requested a review from beeme1mr October 18, 2023 05:06
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #212 (0dab979) into main (d41cea2) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   92.93%   93.21%   +0.27%     
==========================================
  Files          16       16              
  Lines         439      442       +3     
==========================================
+ Hits          408      412       +4     
+ Misses         31       30       -1     
Flag Coverage Δ
unittests 93.21% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
openfeature/client.py 95.60% <ø> (ø)
openfeature/flag_evaluation.py 97.82% <100.00%> (+0.09%) ⬆️
openfeature/provider/in_memory_provider.py 100.00% <100.00%> (+1.88%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@federicobond federicobond force-pushed the flag-metadata branch 2 times, most recently from 4bb468f to ada2073 Compare October 18, 2023 05:19
@beeme1mr beeme1mr merged commit 88a204d into open-feature:main Oct 18, 2023
@federicobond federicobond deleted the flag-metadata branch October 20, 2023 07:02
This was referenced Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants