-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify build and dependencies configuration #208
Conversation
9c2c0d8
to
67c9297
Compare
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 92.93% 92.93%
=======================================
Files 16 16
Lines 439 439
=======================================
Hits 408 408
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@beeme1mr can I ask you for a review of this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Looks good to me. Thank you!
Is it fine to use a requirement.txt in a library with no runtime dependencies? I think you mentioned in a previous conversation that it's ok but I wanted to double-check.
No worries! Yes, requirements.txt exists only for contributors and should contain all dependencies needed for dev. |
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
24de58a
to
8f3deef
Compare
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
63d91f2
to
68d2bf9
Compare
This PR
Unifies both python repository configurations as much as possible, removes unnecessary complexity, and streamlines the contribution process.
Changes can be reviewed commit by commit.