Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify build and dependencies configuration #208

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

federicobond
Copy link
Member

This PR

Unifies both python repository configurations as much as possible, removes unnecessary complexity, and streamlines the contribution process.

Changes can be reviewed commit by commit.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #208 (68d2bf9) into main (059b54a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files          16       16           
  Lines         439      439           
=======================================
  Hits          408      408           
  Misses         31       31           
Flag Coverage Δ
unittests 92.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
openfeature/client.py 95.60% <ø> (ø)
openfeature/flag_evaluation.py 97.72% <ø> (ø)
openfeature/hook/__init__.py 86.11% <ø> (ø)
openfeature/provider/in_memory_provider.py 98.11% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@federicobond federicobond requested a review from beeme1mr October 9, 2023 05:41
@federicobond
Copy link
Member Author

@beeme1mr can I ask you for a review of this?

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looks good to me. Thank you!

Is it fine to use a requirement.txt in a library with no runtime dependencies? I think you mentioned in a previous conversation that it's ok but I wanted to double-check.

@federicobond
Copy link
Member Author

No worries! Yes, requirements.txt exists only for contributors and should contain all dependencies needed for dev.

@federicobond federicobond merged commit 4314ef7 into open-feature:main Oct 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants