Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
leohoare committed Nov 8, 2024
1 parent c2666b4 commit cadd4ed
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 13 deletions.
8 changes: 6 additions & 2 deletions openfeature/api.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import typing

from openfeature import _event_support
from openfeature.client import OpenFeatureClient, AsyncOpenFeatureClient
from openfeature.client import AsyncOpenFeatureClient, OpenFeatureClient
from openfeature.evaluation_context import EvaluationContext
from openfeature.event import (
EventHandler,
Expand Down Expand Up @@ -38,9 +38,13 @@ def get_client(
) -> OpenFeatureClient:
return OpenFeatureClient(domain=domain, version=version)

def get_client_async(domain: typing.Optional[str] = None, version: typing.Optional[str] = None) -> OpenFeatureClient:

def get_client_async(
domain: typing.Optional[str] = None, version: typing.Optional[str] = None
) -> AsyncOpenFeatureClient:
return AsyncOpenFeatureClient(domain=domain, version=version)


def set_provider(
provider: FeatureProvider, domain: typing.Optional[str] = None
) -> None:
Expand Down
26 changes: 15 additions & 11 deletions openfeature/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def get_integer_details(
evaluation_context,
flag_evaluation_options,
)

def get_float_value(
self,
flag_key: str,
Expand All @@ -204,7 +204,7 @@ def get_float_value(
evaluation_context,
flag_evaluation_options,
).value

def get_float_details(
self,
flag_key: str,
Expand Down Expand Up @@ -448,7 +448,6 @@ def _create_provider_evaluation(
error_message=resolution.error_message,
)


def add_handler(self, event: ProviderEvent, handler: EventHandler) -> None:
_event_support.add_client_handler(self, event, handler)

Expand All @@ -470,6 +469,7 @@ def _typecheck_flag_value(value: typing.Any, flag_type: FlagType) -> None:
if not isinstance(value, _type):
raise TypeMismatchError(f"Expected type {_type} but got {type(value)}")


class AsyncOpenFeatureClient:
def __init__(
self,
Expand Down Expand Up @@ -611,7 +611,7 @@ async def get_float_details(
evaluation_context,
flag_evaluation_options,
)

async def get_object_value(
self,
flag_key: str,
Expand All @@ -625,7 +625,7 @@ async def get_object_value(
evaluation_context,
flag_evaluation_options,
).value

async def get_object_details(
self,
flag_key: str,
Expand Down Expand Up @@ -757,7 +757,9 @@ async def evaluate_flag_details( # noqa: PLR0915
return flag_evaluation

except OpenFeatureError as err:
await error_hooks_async(flag_type, hook_context, err, reversed_merged_hooks, hook_hints)
await error_hooks_async(
flag_type, hook_context, err, reversed_merged_hooks, hook_hints
)

return FlagEvaluationDetails(
flag_key=flag_key,
Expand All @@ -773,7 +775,9 @@ async def evaluate_flag_details( # noqa: PLR0915
"Unable to correctly evaluate flag with key: '%s'", flag_key
)

await error_hooks_async(flag_type, hook_context, err, reversed_merged_hooks, hook_hints)
await error_hooks_async(
flag_type, hook_context, err, reversed_merged_hooks, hook_hints
)

error_message = getattr(err, "error_message", str(err))
return FlagEvaluationDetails(
Expand All @@ -785,8 +789,9 @@ async def evaluate_flag_details( # noqa: PLR0915
)

finally:
await after_all_hooks_async(flag_type, hook_context, reversed_merged_hooks, hook_hints)

await after_all_hooks_async(
flag_type, hook_context, reversed_merged_hooks, hook_hints
)

async def _create_provider_evaluation(
self,
Expand Down Expand Up @@ -840,9 +845,8 @@ async def _create_provider_evaluation(
error_message=resolution.error_message,
)


def add_handler(self, event: ProviderEvent, handler: EventHandler) -> None:
_event_support.add_client_handler(self, event, handler)

def remove_handler(self, event: ProviderEvent, handler: EventHandler) -> None:
_event_support.remove_client_handler(self, event, handler)
_event_support.remove_client_handler(self, event, handler)

0 comments on commit cadd4ed

Please sign in to comment.