-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> - adds this new feature ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes #1234523 ### Notes <!-- any additional notes for this PR --> ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> ### How to test <!-- if applicable, add testing instructions under this section --> Signed-off-by: Todd Baert <[email protected]>
- Loading branch information
Showing
8 changed files
with
29 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,18 +44,20 @@ jobs: | |
with: | ||
github_token: ${{ github.token }} | ||
- name: Checkout repository | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
# Run breaking change detection against the last commit | ||
- uses: bufbuild/buf-breaking-action@v1 | ||
with: | ||
input: protobuf | ||
against: 'https://github.com/open-feature/schemas.git#branch=main,ref=HEAD~1,subdir=protobuf' | ||
|
||
|
||
validate-schema: | ||
validate-and-sync-schema: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/checkout@v4 | ||
# with: | ||
# ref: ${{ github.head_ref }} | ||
|
||
# Use ajv to validate schema | ||
- name: Setup node | ||
|
@@ -72,9 +74,17 @@ jobs: | |
- name: Validate Schema | ||
run: make test | ||
|
||
# Ensure there is no diff when make gen-schema-json is run | ||
- run: make gen-schema-json | ||
- name: Check no diff | ||
# Sync JSON schemas from YAML versions | ||
- name: Sync JSON from YAML | ||
run: | | ||
if [ ! -z "$(git status --porcelain)" ]; then echo "JSON schema generation produced diff. Run 'make gen-schema-json' and commit results."; exit 1; fi | ||
make gen-schema-json | ||
if [ ! -z "$(git status --porcelain)" ]; then | ||
echo "JSON schema generation produced diff, regenerating and committing result..."; | ||
git config --global user.name "validate-and-sync-schema-job" | ||
git config --global user.email "[email protected]" | ||
git add json/*.json && git commit --amend --no-edit | ||
git push | ||
else | ||
echo "No delta between YAML and JSON schemas, finishing..." | ||
fi | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,8 +21,9 @@ jobs: | |
id: release | ||
with: | ||
command: manifest | ||
token: ${{secrets.GITHUB_TOKEN}} | ||
token: ${{secrets.RELEASE_PLEASE_ACTION_TOKEN}} | ||
default-branch: main | ||
signoff: "OpenFeature Bot <[email protected]>" | ||
outputs: | ||
releases_created: ${{ steps.release.outputs.releases_created }} | ||
# these are generated by release-please b/c this is in a manifest repo. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
0.2.5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters