-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: revert full schema versioning (#166)
Reverts #163. Though there's a lot of benefits, the maintenance burden here is too high. It means we will need to update the schema version everywhere, frequently. For example, we'd have to update it in places like this: https://github.com/open-feature/java-sdk-contrib/blob/ae21165c2bd65cad325e66e8373fe38da8a98baf/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java#L46-L47 . I think this will be too error prone and too much of a maintenance burden for little benefit. I'm reverting back to only major version-based versioning. Signed-off-by: Todd Baert <[email protected]>
- Loading branch information
Showing
6 changed files
with
12 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ on: | |
pull_request: | ||
|
||
permissions: | ||
contents: write | ||
contents: read | ||
|
||
env: | ||
GO_VERSION: 1.22 | ||
|
@@ -52,12 +52,10 @@ jobs: | |
against: 'https://github.com/open-feature/schemas.git#branch=main,ref=HEAD~1,subdir=protobuf' | ||
|
||
|
||
validate-and-sync-schema: | ||
validate-schema: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
ref: ${{ github.head_ref }} | ||
|
||
# Use ajv to validate schema | ||
- name: Setup node | ||
|
@@ -74,18 +72,9 @@ jobs: | |
- name: Validate Schema | ||
run: make test | ||
|
||
# Sync JSON schemas from YAML versions | ||
- name: Sync JSON from YAML | ||
# Ensure there is no diff when make gen-schema-json is run | ||
- run: make gen-schema-json | ||
- name: Check no diff | ||
run: | | ||
make gen-schema-json | ||
if [ ! -z "$(git status --porcelain)" ]; then | ||
echo "JSON schema generation produced diff, regenerating and committing result..."; | ||
git config --global user.name "validate-and-sync-schema-job" | ||
git config --global user.email "[email protected]" | ||
git add json/*.json | ||
git commit -m 'chore: sync json schema from yaml' -s | ||
git push | ||
else | ||
echo "No delta between YAML and JSON schemas, finishing..." | ||
fi | ||
if [ ! -z "$(git status --porcelain)" ]; then echo "JSON schema generation produced diff. Run 'make gen-schema-json' and commit results."; exit 1; fi | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters