Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Reduce docker image size using multi-stage build. #671

Merged
merged 13 commits into from
May 13, 2019
Merged

Feature: Reduce docker image size using multi-stage build. #671

merged 13 commits into from
May 13, 2019

Conversation

leikao
Copy link
Contributor

@leikao leikao commented Jan 22, 2019

Reduce docker image size from 591MB to 195MB.

Original docker image size:

falcon-plus              dev              721ed5bd17ec        About an hour ago   591MB

Final docker image size:

falcon-plus              dev2             0530306002ab        9 seconds ago       195MB

@laiwei laiwei self-requested a review March 27, 2019 02:09
laiwei
laiwei reviewed Apr 30, 2019
View reviewed changes
Copy link
Member

@laiwei laiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you divide the PR to two separated ones?

@laiwei laiwei merged commit c3683cd into open-falcon:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laiwei laiwei laiwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leikao @laiwei