Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid full reindex_studio on deployment #7

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

pomegranited
Copy link
Member

@pomegranited pomegranited commented Jan 14, 2025

and just use --init instead.

Ensures this plugin's initialization uses the same arguments as in tutor core.

See openedx/frontend-app-authoring#1456 (comment).

Private-ref: FAL-4017

Testing instructions

  1. Check the code change against its equivalent in tutor core.
  2. Ensure the arguments passed to reindex_studio are correct and valid.

Copy link
Member

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@pomegranited pomegranited merged commit 0b4c7d7 into main Jan 14, 2025
@pomegranited pomegranited deleted the jill/reindex-studio-init branch January 14, 2025 04:48
@bradenmacdonald
Copy link
Member

bradenmacdonald commented Jan 14, 2025

@pomegranited We shouldn't need this plugin anymore? Both Tutor main (Open edX master) and Tutor 19 (sumac) now have Meilisearch built in. You can disable/uninstall this plugin (though it's a bit of a hassle to switch from the plugin version to the Tutor built-in version because the built-in one uses an old version of Meilisearch. So the best way is to delete the meilisearch index data files and all the tutor MEILI... settings in config.yml)

Edit: I guess if you are running a Redwood version of Tutor, you'd still need this.

@pomegranited
Copy link
Member Author

@bradenmacdonald Ya, I worked that out eventually.. I thought our tagging-preview still relied on it (because our tutor@nightly deployments used to), and had only just today moved my local devstack off it.

But at this change at least makes the deployments more workable in Redwood, and ensures the plugin works the same as what ended up in tutor@main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants