Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add id, scheme, uri, wasDerivedFrom properties #11

Open
wants to merge 11 commits into
base: 1.1
Choose a base branch
from

Conversation

odscjen
Copy link

@odscjen odscjen commented Nov 29, 2024

@odscjen
Copy link
Author

odscjen commented Nov 29, 2024

Renamed codelist as it's no longer an extension to the Classification object's codelist

@odscjen
Copy link
Author

odscjen commented Nov 29, 2024

Realised needed the codelist to have the same name to allow the codes to be used in the wasDerivedFrom Classification object. No idea why it's giving an error now though, maybe because it's patching to 1.2 and in 1.2 this codelist has been renamed to classificationScheme rather than itemClassificationScheme?

Copy link
Member

@duncandewhurst duncandewhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're probably right about +itemClassificationScheme.csv needing to be renamed to +classificationScheme.csv.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
release-schema.json Outdated Show resolved Hide resolved
release-schema.json Outdated Show resolved Hide resolved
release-schema.json Outdated Show resolved Hide resolved
release-schema.json Outdated Show resolved Hide resolved
release-schema.json Outdated Show resolved Hide resolved
@odscjen
Copy link
Author

odscjen commented Dec 3, 2024

I've left the codelist as itemClassificationScheme.csv so that it remains compatible with 1.1.5, but the answer to the tests faililng appeared to be removing the "+" sign from the start of the codelist when it's declared in the schema so I've done that

@odscjen odscjen requested a review from jpmckinney December 3, 2024 10:19
@duncandewhurst
Copy link
Member

Ah, of course! Good catch :-)

release-schema.json Outdated Show resolved Hide resolved
release-schema.json Outdated Show resolved Hide resolved
release-schema.json Outdated Show resolved Hide resolved
release-schema.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legal basis: object to specify legislation from which the legal basis was derived
3 participants