Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Automatically create namespace if its not found in hubaddon install command #457

Merged

Conversation

RokibulHasan7
Copy link
Member

Summary

Related issue(s)

Fixes #

@JustinKuli
Copy link
Member

JustinKuli commented Oct 29, 2024

/hold for dhaiducek and/or nitpick.

Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one nitpick, I think it looks great!

pkg/cmd/install/hubaddon/exec.go Outdated Show resolved Hide resolved
Signed-off-by: Rokibul Hasan <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Oct 29, 2024
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @RokibulHasan7! I'm not so sure clusteradm should be in the business of creating the namespace without an additional flag. Since the namespace is provided via a --namespace flag, if a namespace is misspelled with a manual command, the current flow wouldn't give the user a heads-up that their namespace is wrong, but I could see this being helpful with automation. If that makes sense, would you add a --create-namespace flag to gate this code?

Signed-off-by: Rokibul Hasan <[email protected]>
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Adding additional reviewers for awareness and approval.

/cc @qiujian16 @zhujian7

Copy link

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli, RokibulHasan7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhujian7
Copy link
Member

LGTM

@dhaiducek
Copy link
Member

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 198563c into open-cluster-management-io:main Oct 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants