-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Automatically create namespace if its not found in hubaddon install command #457
🌱 Automatically create namespace if its not found in hubaddon install command #457
Conversation
…ommand Signed-off-by: Rokibul Hasan <[email protected]>
/hold for dhaiducek and/or nitpick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one nitpick, I think it looks great!
Signed-off-by: Rokibul Hasan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @RokibulHasan7! I'm not so sure clusteradm
should be in the business of creating the namespace without an additional flag. Since the namespace is provided via a --namespace
flag, if a namespace is misspelled with a manual command, the current flow wouldn't give the user a heads-up that their namespace is wrong, but I could see this being helpful with automation. If that makes sense, would you add a --create-namespace
flag to gate this code?
Signed-off-by: Rokibul Hasan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli, RokibulHasan7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
/unhold |
198563c
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #