-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add command clusteradm get placements #158
feat: add command clusteradm get placements #158
Conversation
example output:
|
we might want to show more details, such as the clusters in the related decisions |
72fa4ad
to
a600356
Compare
use a slice of cluster names to replace the number
|
/hold |
a600356
to
a75ff47
Compare
a75ff47
to
27511f4
Compare
@qiujian16 PTAL |
27511f4
to
d513cc3
Compare
should we print table by default or tree by default? I think we are not quite consistent on other commands. |
@qiujian16 maybe we should use tree as the default get output format? some command can not print as table, like |
some may not have tree format, like |
currently i've set tree to default. i will ok, will do this in #174 |
Signed-off-by: ycyaoxdu <[email protected]>
d513cc3
to
0abfb86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, ycyaoxdu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Signed-off-by: ycyaoxdu [email protected]