Explicitly disable the feature gate that is enabled by default (#456)

Signed-off-by: zhujian <[email protected]>
open-cluster-management-io · Oct 29, 2024 · fae815d · fae815d
1 parent e5a4b77
commit fae815d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pkg/genericclioptions/feature_gates.go b/pkg/genericclioptions/feature_gates.go
@@ -20,7 +20,6 @@ func init() {
 
 	// Update default features
 	utilruntime.Must(HubMutableFeatureGate.SetFromMap(map[string]bool{string(ocmfeature.DefaultClusterSet): true}))
-	utilruntime.Must(SpokeMutableFeatureGate.SetFromMap(map[string]bool{string(ocmfeature.AddonManagement): true}))
 }
 
 func ConvertToFeatureGateAPI(featureGates featuregate.MutableFeatureGate, defaultFeatureGate map[featuregate.Feature]featuregate.FeatureSpec) []operatorv1.FeatureGate {
@@ -34,6 +33,9 @@ func ConvertToFeatureGateAPI(featureGates featuregate.MutableFeatureGate, defaul
 		}
 		if featureGates.Enabled(feature) {
 			features = append(features, operatorv1.FeatureGate{Feature: string(feature), Mode: operatorv1.FeatureGateModeTypeEnable})
+		} else if defaultFeatureGate[feature].Default {
+			// Explicitly disable the feature gate that is enabled by default
+			features = append(features, operatorv1.FeatureGate{Feature: string(feature), Mode: operatorv1.FeatureGateModeTypeDisable})
 		}
 	}
 

diff --git a/pkg/genericclioptions/feature_gates_test.go b/pkg/genericclioptions/feature_gates_test.go
@@ -27,7 +27,9 @@ func TestConvertToFeatureGateAPI(t *testing.T) {
 				return fg
 			},
 			defaultFeatureGate: ocmfeature.DefaultHubAddonManagerFeatureGates,
-			expected:           []operatorv1.FeatureGate{},
+			expected: []operatorv1.FeatureGate{
+				{Feature: "AddonManagement", Mode: operatorv1.FeatureGateModeTypeDisable},
+			},
 		},
 		{
 			name: "enable default feature gate",