bugfix: usersearchindex without corresponding user object should be i…

…gnored when searching users by email or username
opdt · Nov 6, 2024 · 93ecb99 · 93ecb99
1 parent a079ec9
commit 93ecb99
Showing 1 changed file with 40 additions and 13 deletions.
diff --git a/...a/de/arbeitsagentur/opdt/keycloak/cassandra/user/persistence/CassandraUserRepository.java b/...a/de/arbeitsagentur/opdt/keycloak/cassandra/user/persistence/CassandraUserRepository.java
@@ -21,11 +21,14 @@
 import de.arbeitsagentur.opdt.keycloak.cassandra.user.persistence.entities.*;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Set;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 import java.util.stream.StreamSupport;
+import lombok.extern.jbosslog.JBossLog;
 
+@JBossLog
 public class CassandraUserRepository extends TransactionalRepository<User, UserDao>
     implements UserRepository {
   private static final String USERNAME = "username";
@@ -54,13 +57,22 @@ public User findUserByEmail(String realmId, String email) {
       return null;
     }
 
-    UserSearchIndex user =
-        dao.findUsers(realmId, EMAIL, email).all().stream().findFirst().orElse(null);
-    if (user == null) {
+    List<User> users =
+        dao.findUsers(realmId, EMAIL, email).all().stream()
+            .map(idx -> findUserById(realmId, idx.getUserId()))
+            .filter(Objects::nonNull)
+            .toList();
+
+    if (users.size() > 1) {
+      log.warn("Found multiple users with email: " + email);
       return null;
     }
 
-    return findUserById(realmId, user.getUserId());
+    if (users.isEmpty()) {
+      return null;
+    }
+
+    return users.getFirst();
   }
 
   @Override
@@ -69,13 +81,22 @@ public User findUserByUsername(String realmId, String username) {
       return null;
     }
 
-    UserSearchIndex user =
-        dao.findUsers(realmId, USERNAME, username).all().stream().findFirst().orElse(null);
-    if (user == null) {
+    List<User> users =
+        dao.findUsers(realmId, USERNAME, username).all().stream()
+            .map(idx -> findUserById(realmId, idx.getUserId()))
+            .filter(Objects::nonNull)
+            .toList();
+
+    if (users.size() > 1) {
+      log.warn("Found multiple users with username: " + username);
       return null;
     }
 
-    return findUserById(realmId, user.getUserId());
+    if (users.isEmpty()) {
+      return null;
+    }
+
+    return users.getFirst();
   }
 
   @Override
@@ -84,16 +105,22 @@ public User findUserByUsernameCaseInsensitive(String realmId, String username) {
       return null;
     }
 
-    UserSearchIndex user =
+    List<User> users =
         dao.findUsers(realmId, USERNAME_CASE_INSENSITIVE, username).all().stream()
-            .findFirst()
-            .orElse(null);
+            .map(idx -> findUserById(realmId, idx.getUserId()))
+            .filter(Objects::nonNull)
+            .toList();
 
-    if (user == null) {
+    if (users.size() > 1) {
+      log.warn("Found multiple users with username (case insensitive): " + username);
       return null;
     }
 
-    return findUserById(realmId, user.getUserId());
+    if (users.isEmpty()) {
+      return null;
+    }
+
+    return users.getFirst();
   }
 
   @Override