Add richer metadata to the analysis aggregation query#922
Merged
Conversation
Member
hellais
commented
Jan 15, 2025
hellais
commented
- Move SQL query to other module
- Return Loni values inside of the analysis aggregate
- Adjust the calculations of anomaly,confirmed and failure
* Move SQL query to other module * Return Loni values inside of the analysis aggregate * Adjust the calculations of anomaly,confirmed and failure
The greatest function will not ignore NULL values and instead return NULL as output
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 911-add-more-test-to-oonidata-endpoints #922 +/- ##
==========================================================================
Coverage ? 98.19%
==========================================================================
Files ? 19
Lines ? 1440
Branches ? 48
==========================================================================
Hits ? 1414
Misses ? 26
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Base automatically changed from
911-add-more-test-to-oonidata-endpoints
to
master
January 24, 2025 12:41
This test used to assert that anomaly count should be in every entry in the results of the aggregation analysis, but we droped that in favor of Loni values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.