-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reserved system name checks when creating templates #746
base: master
Are you sure you want to change the base?
fix: reserved system name checks when creating templates #746
Conversation
…ient logic for determining resource counts
… sure they don't allow sys- prefixed names. Also updated workspace creation so that the workflow templates created by workspace templates have a sys- prefix.
chore: Add issue templates
fix: Add migration for changes in TFOD and CVAT template
Code looks good, need to go through test cases. |
Point of concern.
|
@aleksandrmelnikov Ah, good catch. I'll add a migration to update the old names. |
…rgo workflow templates.
…ifies the code a little.
fix: Move env vars to workspace creation
…les into their own subdirectory for easier separation of files.
feat: upgrade grpc
chore: Update demo note
… sure they don't allow sys- prefixed names. Also updated workspace creation so that the workflow templates created by workspace templates have a sys- prefix.
…rgo workflow templates.
…ifies the code a little.
…afilor/core into fix/onepanelio.core.256-reserved.names
What this PR does:
Updated workspace templates' associated workflow templates to have a sys- prefix to indicate it is a system resource.
Also added checks to workflow/workspace template creation so they don't allow sys- prefixes.
Which issue(s) this PR fixes:
Fixes #256
Special notes for your reviewer:
To test:
Try creating a workflow template and workspace template with a sys- prefixed name. You should get an error.
Try creating a workspace template and check in the database that the newly created workflow template has a sys- prefixed name.
Checklist
Please check if applies
Required