Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating openssl version to 3.0.13 #20

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

Vishal1309
Copy link

No description provided.

@Vishal1309
Copy link
Author

I don't know how to update the SHAsums here, can anyone help out please? @larskanis @junaruga @MSP-Greg .

Also, does this change ensure that rubyinstaller package will have openssl 3.0.13 linked with it... lets say rubyinstaller for 3.2.2 ruby?

@junaruga
Copy link

Maybe this one.

$ ./configure --with-openssl-dir=/path/to/your/openssl

https://stackoverflow.com/questions/32885960/building-ruby-and-specifying-openssl-directory

@MSP-Greg
Copy link
Contributor

@Vishal1309

Enthusiastic people trying to learn about OSS are always appreciated. But, opening PR's as a means to ask a question is not appropriate.

Also, does this change ensure that rubyinstaller package will have openssl 3.0.13 linked with it... lets say rubyinstaller for 3.2.2 ruby?

Sort of.

First of all, you've changed a file in the mingw-w64-ruby33 folder, which only affects Ruby 3.3.z builds. If you want to change 3.2.z builds, you need to change the file in the mingw-w64-ruby32 folder.

Secondly, Ruby 3.2.z builds and later are currently using the most recent MSYS2 OpenSSL package, which is 3.3.0. Why would a PR be accepted forcing it back to 3.0.13?

It's not clear what you're trying to do.

JFYI, if you're wondering about the most recent Ruby builds, see the most recent Actions run in https://github.com/MSP-Greg/github-actions-ruby-info/actions. Each run shows data for several Ruby versions, across several OS's/platforms.

@junaruga
Copy link

junaruga commented May 22, 2024

Just for your information, I am unsubscribing from this PR, as I don't want to receive the notification for each commit update. But feel free to ask me questions if you want to ask questions related to OpenSSL or FIPS. But I don't know about this repository, and I am not familiar with Windows things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants