[DeviceASAN] Fix quarantined memory and related info not release when context is released. #2505
Conversation
yingcong-wu
changed the title
|
Please sync these fix to msan as well. |
Sync some fixes to msan. |
| if (IsFromQuarantined) { | ||
| getContext()->logger.info("Quarantine Free: {}", | ||
| (void *)AI->AllocBegin); | ||
| } else { | ||
| getContext()->logger.info("Free: {}", (void *)AI->AllocBegin); | ||
| } |
There was a problem hiding this comment.
I feel not comfortable that "IsFromQuarantined" is just for different logger, it'd be better to move logger before calling "releaseAllocationNoCheck".
There was a problem hiding this comment.
That is just a helper function to reduce duplicated codes. If we split that logic to caller, then we would have to repeat the same code in different places, which is quite again the purpose of the function.
There was a problem hiding this comment.
I mean you can just move "getContext()->logger" before calling this function.
There was a problem hiding this comment.
I mean you can just move "getContext()->logger" before calling this function.
Yes, that is what I mean. If we move that logging logic to caller to this help function, then we would have duplicated codes.
Changes:
char*instead ofvoid*, this would make the logger try to print string instead of address, which leads to SEGV since they are not really strings.Quarantineto use shared_ptr instead of the iterator to avoid invalid iterator.releaseAllocationNoCheckto help better do allocation release.Intel/llvm PR: intel/llvm#16467