-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: cmake: unsupported compilers cleanup #2296
base: main
Are you sure you want to change the base?
Conversation
The main driver for this change is cleaning up old workarounds for compiler bugs from codebase and compiler version checks from the build system. The change is driven by RHEL 7 reaching end of support and new versions allow oneDNN to build on RHEL 8 out of the box. |
d65efa8
to
edc62e1
Compare
AArch64 validation is outdated, it is now on ubuntu 22.04 with gcc-10, gcc-13 and clang-17 MacOS-14 is also run in the CI with AppleClang 15 (though the default compiler is determined by GitHub runner images). Also, can you rebase, the CI should be fixed now. |
edc62e1
to
5397f1c
Compare
@theComputeKid I have updated the README entries for AArch64 based on #2294 and what you posted here. |
Is this a draft or would you like me to review? |
5397f1c
to
608ab75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AArch64 looks good to me. I'm always tweaking CI (Arm runners are still new) so if anything changes, I'll change it here too.
@dmitry-gorokhov, @ilya-lavrenov, @vladimir-paramuzov I looked through OpenVINO build documentation, and it specifies that the lowest supported OS is Ubuntu 18.04 and GCC 7.5.0. Release documentation does not have these dependencies and starts at Ubuntu 20.04 (and I assume GCC 8.5.0) but at the same time shows CentOS 7. Since we want to move past GCC 7, can you tell us which documentation (and OS/compiler pair) is correct? |
Ubuntu 20.04 is minimal |
There are some outdated compiler version checks in the implementation:
I would not touch third party components like Xbyak, spdlog and gtest. |
608ab75
to
b537a30
Compare
make test |
b537a30
to
aea91c9
Compare
Build files and documentation cleanup to remove dependencies and hacks for GCC < 8 and Clang < 11.