Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: cmake: unsupported compilers cleanup #2296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spalicki
Copy link
Contributor

Build files and documentation cleanup to remove dependencies and hacks for GCC < 8 and Clang < 11.

@spalicki spalicki self-assigned this Dec 19, 2024
@github-actions github-actions bot added the documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc label Dec 19, 2024
@vpirogov
Copy link
Member

The main driver for this change is cleaning up old workarounds for compiler bugs from codebase and compiler version checks from the build system. The change is driven by RHEL 7 reaching end of support and new versions allow oneDNN to build on RHEL 8 out of the box.

@vpirogov vpirogov requested a review from a team December 19, 2024 20:12
@spalicki spalicki force-pushed the spalicki/old_compilers_cleanup branch from d65efa8 to edc62e1 Compare December 19, 2024 20:54
@theComputeKid
Copy link
Member

theComputeKid commented Dec 20, 2024

AArch64 validation is outdated, it is now on ubuntu 22.04 with gcc-10, gcc-13 and clang-17

MacOS-14 is also run in the CI with AppleClang 15 (though the default compiler is determined by GitHub runner images).

Also, can you rebase, the CI should be fixed now.

@spalicki spalicki force-pushed the spalicki/old_compilers_cleanup branch from edc62e1 to 5397f1c Compare December 20, 2024 18:38
@spalicki
Copy link
Contributor Author

@theComputeKid I have updated the README entries for AArch64 based on #2294 and what you posted here.

README.md Outdated Show resolved Hide resolved
@theComputeKid
Copy link
Member

Is this a draft or would you like me to review?

@spalicki spalicki force-pushed the spalicki/old_compilers_cleanup branch from 5397f1c to 608ab75 Compare December 20, 2024 18:54
@spalicki spalicki marked this pull request as ready for review December 20, 2024 18:54
@spalicki spalicki requested review from a team as code owners December 20, 2024 18:54
Copy link
Member

@theComputeKid theComputeKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AArch64 looks good to me. I'm always tweaking CI (Arm runners are still new) so if anything changes, I'll change it here too.

@spalicki
Copy link
Contributor Author

spalicki commented Dec 30, 2024

@dmitry-gorokhov, @ilya-lavrenov, @vladimir-paramuzov I looked through OpenVINO build documentation, and it specifies that the lowest supported OS is Ubuntu 18.04 and GCC 7.5.0. Release documentation does not have these dependencies and starts at Ubuntu 20.04 (and I assume GCC 8.5.0) but at the same time shows CentOS 7. Since we want to move past GCC 7, can you tell us which documentation (and OS/compiler pair) is correct?

@ilya-lavrenov
Copy link
Contributor

Ubuntu 20.04 is minimal
CentOS 7 is supported with non default compiler (we use manylinux docker image with gcc-10)
We also support RHEL 8.4 with gcc 8.5

@vpirogov
Copy link
Member

There are some outdated compiler version checks in the implementation:

I would not touch third party components like Xbyak, spdlog and gtest.

@spalicki spalicki force-pushed the spalicki/old_compilers_cleanup branch from 608ab75 to b537a30 Compare January 2, 2025 20:58
@spalicki spalicki requested review from a team as code owners January 2, 2025 20:58
@github-actions github-actions bot added platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel component:build labels Jan 2, 2025
@spalicki
Copy link
Contributor Author

spalicki commented Jan 2, 2025

make test

@spalicki spalicki force-pushed the spalicki/old_compilers_cleanup branch from b537a30 to aea91c9 Compare January 2, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants