Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new UI variant for One Dark Theme #311

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jamievlin
Copy link

Add new UI variant for One Dark Theme

Description

Adds a new UI version of one dark theme

Motivation and Context

I am a daily user of the new UI in IntelliJ and the regular one dark theme had different border/spacing than themes for the new UI.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-Functional Change (non-user facing changes)

Checklist:

  • My code follows the code style of this project (./gradlew check passes clean).
    • Tip: If you have lint issues just run ./gradlew :ktlintMainSourceSetFormat.
  • I updated the changelog with the new functionality.

@AregevDev
Copy link

AregevDev commented Oct 26, 2024

Bump. There's no need to copy the new UI dark theme. You can set the parentTheme to ExperimentalDark.
That, and remove the rowHeight attributes from Tree and List.

Works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants