Release 7.0.1 #591
Merged
Release 7.0.1 #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arscan
reviewed
Nov 19, 2024
arscan
reviewed
Nov 19, 2024
| us_core_test_kit (0.9.1) | ||
| inferno_core (>= 0.4.37) | ||
| us_core_test_kit (0.9.2) | ||
| inferno_core (>= 0.5.0) |
There was a problem hiding this comment.
I find this a little surprising on a patch release but if @Jammjammjamm is good with this (I assume it was required here), no objections.
There was a problem hiding this comment.
Before releasing 0.9.0, inferno_core dependency was updated to 0.5.0 using bundle update command. But the gemspec was not updated in that release. I think it would be good to keep gemspec updated also.
There was a problem hiding this comment.
Bumping it in the gemspec wasn't strictly necessary, but it was also one of the test kits that had a problem that was addressed in 0.5.0.
But in general, there is no expectation that the version in the gemspec match what is in Gemfile.lock.
Co-authored-by: Rob Scanlon <[email protected]>
Jammjammjamm
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 7.0.1 incoporate US Core v0.9.2