Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usernames to print covers and fix audit and clearance review pending states #439

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

JohnMwashuma
Copy link
Member

@JohnMwashuma JohnMwashuma commented Nov 13, 2024

Task checklist


  • Print cover updates
  • Fix audit and clearance review pending states related to this issue
  • Fix importing staff list command and add an optional tally id

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 40.54054% with 22 lines in your changes missing coverage. Please review.

Project coverage is 80.69%. Comparing base (ab2cb17) to head (9139e6b).

Files with missing lines Patch % Lines
...pps/tally/management/commands/import_staff_list.py 14.28% 18 Missing ⚠️
tally_ho/apps/tally/templatetags/app_filters.py 78.57% 3 Missing ⚠️
tally_ho/apps/tally/views/clearance.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage   80.75%   80.69%   -0.07%     
==========================================
  Files         145      145              
  Lines        9504     9509       +5     
==========================================
- Hits         7675     7673       -2     
- Misses       1829     1836       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnMwashuma JohnMwashuma merged commit 624e4c7 into master Nov 15, 2024
8 checks passed
@JohnMwashuma JohnMwashuma deleted the print-cover-updates branch November 15, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants