Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Adjust import attributes to new specification #252

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

omrilotan
Copy link
Owner

Issue

Import of JSON modules have changed

Old:

import patterns from "../../src/patterns.json" assert { type: "json" };

New (node 22):

import patterns from "../../src/patterns.json" with { type: "json" };

see https://nodejs.org/api/esm.html#import-attributes

Solution:

Use file load to bridge version gap

@omrilotan omrilotan merged commit d9ff27a into main Apr 26, 2024
10 checks passed
@omrilotan omrilotan deleted the import-attributes branch April 26, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant