Support phantom.app user agent #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Failure seems unrelated to my exact change as far as I can tell (something about Ecosia). I had a clean run locally with |
|
Nice one, thank you. |
omrilotan
reviewed
Mar 29, 2024
|
Ah good call, I saw Phantom.JS but didn't notice it had "bot" in it as well. Thanks for your help fixing this and getting it in! |
|
I appreciate your contribution. This change is included in version 5.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#209 was a little permissive, and blocks popular mobile application https://phantom.app/. Hoping we could restrict the pattern to just PhantomJS to allow Phantom.app traffic to not be recognized as a bot