Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added url matching option to library #4201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndreasThinks
Copy link

I've tried to add the option to match by URL. Still testing this locally, but though I'd open PR in the interim for feedback.

Copy link

vercel bot commented Jul 15, 2024

@AndreasThinks is attempting to deploy a commit to the omnivore Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2024

CLA assistant check
All committers have signed the CLA.

@jacksonh
Copy link
Contributor

One thought is maybe it could be startsWith instead of ===

@jacksonh
Copy link
Contributor

@sywhb can you look at this one?

@sywhb sywhb self-assigned this Jul 18, 2024
@sywhb
Copy link
Contributor

sywhb commented Jul 18, 2024

This filter would only be applied to rules and we have to update another method if we want to apply it to the search function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants