feat: log errors on failed logout #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suprnova32
approved these changes
Jan 20, 2025
Contributor
Author
|
Thanks for the review, @suprnova32! |
|
This would be really useful for us - we're currently getting a lot of these exceptions but don't know what is causing them. Any idea when the gem might be bumped to include this @suprnova32 ? |
Member
|
see #233 |
|
I don't think this is quite working as expected - it looks like the SloLogoutrequest instance expects Happy to put in another PR to fix this unless you just want to change it directly 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mini PR that merely includes actual error messages in logout request validation errors, giving people a chance to find out what's wrong when it's not working.