Locked segments #1127
Open
Locked segments #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-cordonnier
requested review from
Kazephil,
brandelune and
kosivantsov
as code owners
t-cordonnier
force-pushed
the
locked-segments
branch
from
5194b5e
to
a296eb4
Compare
t-cordonnier
force-pushed
the
locked-segments
branch
from
a296eb4
to
4297051
Compare
Kazephil
reviewed
Aug 27, 2024
| @@ -1803,6 +1805,7 @@ WG_SAVE_ORIGIN=Save origin of &translation | |||
| WG_INITIAL_SEGMENT_LOAD_COUNT=Initial number of loaded segments: | |||
| WG_INITIAL_SEGMENT_LOAD_COUNT_TOOLTIP=When a single file has more segments than this, additional segments will be loaded on-demand as you scroll. | |||
| WG_PARA_MARK=Paragraph delimiter: | |||
| WG_SUPPORT_LOCKED_SEGMENTS=Support for locked segments | |||
There was a problem hiding this comment.
I think "Allow segment locking" would be better for this one, if I understand the intent correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the notion of locked segment: when you are in such a segment inside the editor, any attempt to add or delete characters will be rejected - only the navigation keys work, you can escape the segment of course!
Pull request type
Which ticket is resolved?
https://sourceforge.net/p/omegat/feature-requests/1745/ (for tm/enforce)
I am not sure there is a specific ticket for xliff / final but we already discussed it in the mailing lists
About https://sourceforge.net/p/omegat/bugs/1215/ : it does not directly solve the bug, which is in Okapi filter, but once the patch is applied we may have some info we can give to them so that they can use the new feature to solve the bug.