refactor: simplify IParseCallback#addEntry #1117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use default for old addEntry method signature to reduce code duplications. - Update IParseCallback#addEntry to be default - Remove overrides of it - Update ILIASFilter and MagentoFilter to use new one Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
- Update lines for ParseEntry and ExternalTMFactory Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
commented
Aug 31, 2024
miurahr
commented
Aug 31, 2024
| @@ -55,24 +55,46 @@ public interface IParseCallback { | |||
| * @param filter | |||
| * filter which produces entry | |||
| * @param protectedParts | |||
| * (since 3.0.6) protected parts | |||
| * protected parts | |||
| */ | |||
| void addEntryWithProperties(String id, String source, String translation, boolean isFuzzy, String[] props, | |||
There was a problem hiding this comment.
A method addEntryWithProperties has 8 parameters, that breaks a checkstyle rule. Exceeding a number of argument is a signature of design error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use default for old addEntry method signature to reduce code duplications.
Pull request type
refactor
What does this PR change?
Other information