Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce Lucene-Hunspell spellchecker module #1052

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Jun 7, 2024

Pull request type

  • Feature enhancement -> [enhancement]

Which ticket is resolved?

What does this PR change?

Other information

TODO:

@miurahr
Copy link
Member Author

miurahr commented Jun 9, 2024

There is a problem for dependency version conflict. OmegaT 6.1 have a mechanism to encapsulate modules/plugins with individual class loader and avoid referencing from other module/core to look unwanted version of dependency.
It is mandatory to merge here lucene-hunspell module to OmegaT, OmegaT core should separate LT and Lucene to individual modules. It is because the Lucene-Hunspell module can see core dependencies that is Lucene 5.5.5 will cause an error.

@miurahr
Copy link
Member Author

miurahr commented Aug 8, 2024

When this PR is merged into LT project, we can use it.
languagetool-org/languagetool#10810

@miurahr
Copy link
Member Author

miurahr commented Sep 26, 2024

LanguageTools project plan to move to use Lucene 8 in LT 6.6 development.

languagetool-org/languagetool#10810 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant