refactor: GlossaryTextArea: action with lambda #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
commented
Jun 1, 2024
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
commented
Jun 1, 2024
Signed-off-by: Hiroshi Miura <[email protected]>
|
Now ready for review and merge. |
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
changed the title
|
Updated with a feedback in dev-ML discussion that @t-cordonnier suggests lambda instead of old fashioned Action class |
t-cordonnier
requested changes
Jun 9, 2024
| @@ -451,4 +446,29 @@ public void actionPerformed(ActionEvent e) { | |||
| .setPreference(Preferences.GLOSSARY_SORT_BY_LENGTH, sortOrderLocLength.isSelected())); | |||
| menu.add(sortOrderLocLength); | |||
| } | |||
|
|
|||
| private static JMenuItem createMenuItem(String titleKey, String command, Runnable action) { | |||
There was a problem hiding this comment.
If you plan to use the same methodology for main menu, you should move these methods to a common class, for example org.omegat.gui.common.MenuFactory
| private static JMenuItem createMenuItem(String titleKey, String command, ActionListener actionListener) { | ||
| JMenuItem result = new JMenuItem(); | ||
| setLocalizedText(result, OStrings.getString(titleKey)); | ||
| result.setActionCommand(command); |
There was a problem hiding this comment.
I think also action command is not necessary. In the past it was used when same action listener was shared by multiple menus, which is the case in MainWindowMenu actually.
But with a distinct lambda for each menu, does not seem necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor GlossaryTextArea class.
The proposed change improve readability of code and help debug to avoid anonymous action listener class.
Pull request type
refactor
Which ticket is resolved?
What does this PR change?
openWritableGlossaryFileinProjectUICommandclassOther information
dev-ML discussion
https://sourceforge.net/p/omegat/mailman/omegat-development/thread/2ab347a7-536f-4e3b-bac6-a8856c00112d%40northside.tokyo/#msg58776083
Suggest that we can use Java standard Actons interface for menu items