Artifacts

[jburel]

This PR reactivates works done in #127. This is based on GitHub action

Original description:

Support downloading from GitHub releases. Currently limited to:

• Full release tags only (latest isn't supported, nor are partial tag prefixes such as 5.5)
• Only .zip (matches the current behaviour of omego download, but e.g. this means you won't see the Insight.dmg)

E.g.:

$ omego download --github ome/omero-insight --release 5.5.5
Artifacts available for download. Initial partial matching is supported for all except named-components). Alternatively a full filename can be specified to download any artifact, including those not listed.

omerozips:
  imagej-5.5.5
  importer-5.5.5
  insight-5.5.5
zips:
  OMERO.imagej-5.5.5
  OMERO.importer-5.5.5
  OMERO.insight-5.5.5

$ omego download --github ome/omero-insight --release 5.5.5 insight
2020-03-19 17:57:12,123 [omego.artifa] INFO  Checking https://github.com/ome/omero-insight/releases/download/v5.5.5/OMERO.insight-5.5.5.zip
2020-03-19 17:57:12,124 [omego.fileut] INFO  Downloading https://github.com/ome/omero-insight/releases/download/v5.5.5/OMERO.insight-5.5.5.zip
2020-03-19 17:57:24,708 [omego.artifa] INFO  Unzipping OMERO.insight-5.5.5.zip

Edit 01/07:

• partial tag is now supported e.g. 5 or 5.6

omego download --github ome/omero-insight --release 5
or

omego download --github ome/omero-insight --release 5.7

To download the latest in the 5 series of the server

omego download --github ome/openmicroscopy --release 5 server

cc @sbesson

[joshmoore]

No objections if this immediately works for the needed use cases, but longer-term, I assume much of this functionality can be offloaded to gh.

[sbesson]

No objections if this immediately works for the needed use cases, but longer-term, I assume much of this functionality can be offloaded to gh.

Ha, I was exactly testing that

(gh) sbesson@Sebastiens-MacBook-Pro ~ % gh release download -R ome/openmicroscopy v5.6.5 -p 'OMERO.server*zip'
(gh) sbesson@Sebastiens-MacBook-Pro ~ % ls OMERO.server-5.6.5-ice36-b233.zip
OMERO.server-5.6.5-ice36-b233.zip

There possibly a biggest rearchitecture call that includes the deployment of gh on Linux, adding it as dependency to omego etc but a priori it looks like barring the minor/major/latest redirect, gh release download already supports most of this logic

[jburel]

I agree
I look at gh but I did not want to introduce a dependency without prior discussions

The most useful use case at the moment is the ability to do omego download --github ome/openmicroscopy --release 5 server
Like this we won't have to update the installation doc unless we have a major release

Another place where we could use the strategy is ome/omero-documentation#2258
Since I am now downloading the server and extract information from the jar. Like this we could handle doc fixes for v5 and v6. I won't be relying on artifactory for dependencies like BF, omero-server etc. cf. ome/omero-documentation@d7ffef6

[jburel]

the steps we could follow:

• Agree on the omego commands using the current implementation
• Release omego
• Use omego to improve the automation of the release process (can be used in doc and omero-install)
• Review the omego implementation

This will follow a similar path that what we discussed about artifactory vs maven central

[jburel]

One possible limitation with gh commands is that if you install then run a command
you get the message

To get started with GitHub CLI, please run:  gh auth login
Alternatively, populate the GH_TOKEN environment variable with a GitHub API authentication token.

Something we don't have with the current implementation