Don't error on fusesoc library update when sync-version is used for a git-provided library
#724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates the new `test_usecases`-module, which allows to easily/conveniently create tests, that exercise command line executions fo fusesoc. This allows to ergonomically define testcases involving multiple commands.
See olofk#721 for context. This simply uses `git fetch` instead of `git pull` if a specific version is requested. This is a kind of hacky solution, since this won't work if somebody removes the `sync-version` from the `fusesoc.conf`-file (in that case, the code will use `git pull` again, which will fail as before). Since this usecase is not that common, this commit should be enough for now.
jfrimmel
force-pushed
the
git-tag-update
branch
from
28ed11f to
65966f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #721 for context. This PR uses
git fetchinstead ofgit pullwhen on a git tag. This won't cause any errors on git tags and thus the library update won't fail. It even supports switching to a new tag, when thesync-version-field in thefusesoc.conf-file is altered.Best reviewed commit-by-commit:
_fusesoc()-function can be used to run shell commands. I'm a little bit proud of how the test module turned out: there is almost no boilerplate in actual test functions.Fixes #721.