Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for official gowin tool #437

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Add support for official gowin tool #437

merged 5 commits into from
Nov 4, 2024

Conversation

flaminggoat
Copy link
Contributor

@flaminggoat flaminggoat commented Jun 24, 2024

Example core:

  tang_nano_20k:
    default_tool: gowin
    description : Sipeed Tang Nano 20k
    filesets: [rtl, tang_nano_20k]
    flow: gowin
    flow_options:
      tool: gowin
      part: GW2AR-LV18QN88C8/I7
      gowin_options:
        - -multi_boot 1
    toplevel: top

@olofk
Copy link
Owner

olofk commented Jun 25, 2024

Thanks for adding this. Bonus points for also adding tests. Unfortunately this implementation is written for the Tool API that is about to be deprecated, and all new backends must instead support the Flow API. In practice this means adding a file in the tools subdirectory and then probably a short file in the flows subdirectory as well. I am fully aware that I haven't communicated this change very clearly and I apologize for that. Hopefully it's not too much work to change this. I think the efinity files can be useful as examples for how to write these files.

Let me know if you need assistance.

edalize/tools/gowin.py Outdated Show resolved Hide resolved
@olofk
Copy link
Owner

olofk commented Jul 5, 2024

Very good. I think I found a typo, but looks fine otherwise. Appreciate if you could throw in some tests too. Doesn't have to be anything advanced. Check e.g. test_tool_verilator.py for reference and let me know if you have any questions.

@flaminggoat
Copy link
Contributor Author

@olofk I think that should be resolved now

@flaminggoat flaminggoat requested a review from olofk August 5, 2024 21:34
@olofk olofk merged commit dc65687 into olofk:main Nov 4, 2024
1 check passed
@olofk
Copy link
Owner

olofk commented Nov 4, 2024

Sorry for taking so long to get back to this. It looks all fine and dandy. Picked and pushed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants