Fixes URL parsing when basic auth is included in the URL. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran into this Problem today. Would be really nice if this pull request would be accepted |
|
I also ran into this issue quite a while ago and I can also confirm that this solves the issue. |
|
I would really love to see this fix on main |
imhimansu28
approved these changes
Jun 8, 2024
|
Thanks for the approval! |
|
Any updates here ? |
|
No updates? I'm still relying on installing a custom wheel in internal deployments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ollama may be protected by a reverse proxy enforcing basic auth.
When the Ollama URL contains basic auth elements, ollama-python removed them from the URL leading in a HTTP 401 ERROR.
This patch fixes the parsing of the URL so that basic auth elements are not removed.