Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix py_structs import errors across codebase #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kanishkaganguly
Copy link

When installing from source using python3 -m pip install ".[interactive]" and trying to run multical -h, there are import errors across multiple files.
This is running on Python3.8 inside a virtual environment.

Upon investigation, it would appear to be originating from the py_structs package, which seems to be using a different directory structure than what multical is expecting. This might be due to a change upstream, maybe.
This PR fixes all import errors and allows multical -h to run without crashing/errors. Whether calibration actually works is a different issue, and is under testing.

@oliver-batchelor
Copy link
Owner

I have committed a change to setup.py to change the dependency to py_structs < 1.0 (which is where the refactoring h to move the modules around happened).

If you're confident that it still works with these changes, I'm happy to commit it; really, it needs a basic test to check the functionality still works - but I'm not really using this for anything lately, so I've got zero time allocated to work on something like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants