Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blur editor after pressing next/prev #4517

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

azmy60
Copy link
Collaborator

@azmy60 azmy60 commented Jun 11, 2024

There is a bug similar to this #4516. Pressing Tab/Shift+Tab would open the editor for the next cell which is uncommon if we compare it to other tools like Google Sheets and Ms. Excel.

Expected: Pressing tab should blur the editor and then go to the next cell without opening a new cell editor.

Also: this should also fix navigating within cell editor beekeeper-studio/beekeeper-studio#2242

Tabulator

tabulator-nav2

Google Sheets

gsheets-nav2

@olifolkerd
Copy link
Owner

Hey @azmy60

Thanks for the PR.

On this one, while i accept that this behaviour deviates from excel, this is not a spreadsheet application. This is first and foremost a Table application that has recently had spreadsheet functionality added, which is very much the edge usage case as far as the main uses of the library are concerned.

Would you be ok moving this into an option for the module so that this different behaviour can be enabled by the user if desired?

Cheers

Oli :)

@olifolkerd
Copy link
Owner

Hey @azmy60

Just wondering what your thoughts were on this one?

Cheers

Oli :)

@azmy60
Copy link
Collaborator Author

azmy60 commented Oct 3, 2024

Hey @olifolkerd , sorry I missed looking into this one earlier, and of course I can make this as an option instead of the default behavior. Expect me to work on this next week :)

@azmy60
Copy link
Collaborator Author

azmy60 commented Oct 8, 2024

@olifolkerd I just added a new option to the Select Range module. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants