BasicVertical renderer restores scroll position in rerenderRows #4481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
BasicVertical
renderer remember the scroll position whenrerenderRows
is called so it can be restored after clearing and rendering the rows.This fixes #4469 when Progressive Scrolling is used with the Basic renderer, the table scrolls back to the top when a new page is loaded. This is because all rows are cleared and re-added.
Side note/Suggestion: The documentation at https://tabulator.info/docs/6.2/render#vertical for
rerenderRows
says that the rows should be cleared AND rendered before the callback is called. However the current code for both the Basic and Virtual renderers clear then call the callback and then render the rows. Might be prudent to update the documentation to reflect this.