Update and rename build.yml to deploy.yml #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a GitHub Pages deployment stage to the build workflow, which I thus renamed to “deploy.yml” I’m not sure if you’re interested in adding this or not, but I figured it would be worth proposing the change anyway. Note: I have _not_ actually tested this, because the repo I use for my own live DG site is private and therefore won’t let me use Pages for free. So if you decide to incorporate this change, please keep that in mind — there might be a missing parameter or a typo or something.
|
I tested this against a basic site, deploying a couple of times, but then I decided I wanted my site private again. |
|
Seems simply adding a deploy step wasn't a great idea, because that workflow runs for PRs. So I replaced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a GitHub Pages deployment stage to the build workflow, which I thus renamed to “deploy.yml”
I’m not sure if you’re interested in adding this or not, but I figured it would be worth proposing the change anyway.
Note: I have not actually tested this, because the repo I use for my own live DG site is private and therefore won’t let me use Pages for free. So if you decide to incorporate this change, please keep that in mind — there might be a missing parameter or a typo or something. Therefore I have marked this as a draft.
I’m not sure if I’ll use GH Pages myself, but if I do test this myself I’ll update the PR. Otherwise it’s there in case you’re interested in testing and merging it.
Thanks for the awesome repository and great documentation! If I get confident enough in my own site and add a little more content I might make a PR to add it to the list, but I’m shy… 🙈