Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace H1 with Span in the Navbar #220

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Derillo
Copy link

@Derillo Derillo commented Oct 19, 2023

a. Cause: Duplicate h1 in code
layouts/note.njk (who defines h1)

b. Solution: replace h1 with span

  • src/site/_includes/components/navbar.njk
  • /src/site/_includes/components/filetreeNavbar.njk
  • src/site/_includes/components/filetree.njk

c. todo: use the appropriate style class

a. Cause: Duplicate h1 in code
-  src/site/_includes/components/navbar.njk usa
-  src/site/_includes/layouts/note.njk usa

b. Solution: Change h1 with span in navbar

c. todo: use the appropriate style class
replace h1 with span in filetree
replace h1 with span in filetreeNavbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant