fixed ad-title rendering #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyj0824
commented
Aug 29, 2023
| const titleDiv = titleLine | ||
| ? `<div class="callout-title"><div class="callout-title-inner">${titleLine}</div>${foldDiv}</div>` | ||
| : ""; | ||
| ? `<div class="callout-title"><div class="callout-title-inner">${md.render(titleLine)}</div>${foldDiv}</div>` |
There was a problem hiding this comment.
When no title is given, it should output the admonition type in the title div.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issues #200
I found a small flaw in the rendering of the callouts(admonitions) :)
The codeblock-style admonition title(with markdown) cannot be corretly rendered, which it could be done in the Obsidian.
And it's easy to fix it. All you need to do is adding
md.render(). Would you mind to add this in the next release?